-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add folder and file to .test.ts and .spec.ts from Typescript #214
Conversation
I think it would just be changing the folder, I really like the way .spec and .test look now with that orange color. What do you think @miguelsolorio? |
I'm not a big fan of the more graphical test tube, most of the theme is singular lines. If you could provide some alternative examples that would be great otherwise I'm happy to design some. |
I agree with you. Maybe we should use folder green or folder red for tests folders. But They are only suggestions, I will send a PR with the idea and tell me what you think. |
I like how the folders look with the new icons, I believe that for file icons it is not necessary but for folders I like how they differ from other folders |
I would also only add this for folders, files already have an existing pattern of using blue = source and orange = test from previous file icon themes so I'd like to keep to that. |
I will revert the file icons and keep the changes to the folder icons |
@miguelsolorio I updated the description with an image showing the result |
@the-spanish-guy I think you may have missed my original comment about not being a fan of the 3D test tubes, can you provide some different options that fit with the rest of the theme? Otherwise I am happy to add one and close this PR. |
Description
Issue
Resolves #203
Preview